feat: make blockNumberOrTagOrHash a required parameter for eth_getStorageAt (#3839) #3879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…StorageAt` (hiero-ledger#3839) Signed-off-by: Michał Walczak <michal.walczak@arianelabs.com>
arianejasuwienas
previously approved these changes
Jun 26, 2025
arianejasuwienas
dismissed
their stale review
Let's collect two other approvals anyway.
…tion-with-Ethereum's-OpenRPC-specification
mwb-al
commented
Jun 26, 2025
| @@ -2016,22 +2016,18 @@ describe('RPC Server', function () { | |||
| } | |||
| }); | |||
|
|
|||
| it('validates parameter 2 is valid block tag', async function () { | |||
| it('validates parameter 2 exists', async function () { | |||
There was a problem hiding this comment.
Here I modified the duplicated test (see: https://github.com/hiero-ledger/hiero-json-rpc-relay/pull/3879/files#diff-9da69620d32f31dfe2aa30404c54c35075885b4375a9809a4191ae9e54b6d6ebL2000)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the
eth_getStorageAtmethod to require theblockNumberOrTagOrHashparameter, aligning it with the Ethereum OpenRPC specification. It also adjusts validation rules, method signature, and tests to enforce this requirement.Related issue(s):
Fixes #3839
Checklist